Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use material icons with Newspack color #46

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Mar 19, 2021

All Submissions:

Changes proposed in this Pull Request:

A small refactor which replaces hard-coded Material Design SVGs with icons from the Material Design Icons NPM package. Also ensures that all icons are displayed with the Newspack brand color where appropriate. Shouldn't affect any plugin behavior.

Also updates some docblock comments to maintain consistency between the use of "WordPress" vs. "External" dependencies.

How to test the changes in this Pull Request:

  1. Check out this branch, run npm ci && npm run build.
  2. On a post or page, add a Curated List block. Confirm that the block icon is now blue to match other Newspack icons:

Screen Shot 2021-03-19 at 4 52 06 PM

  1. Select "Specific Listings" mode. Add blocks for each listing type to the list (you'll need at least one published listing of each type to add them to the list block). Confirm that the individual icons for each different type are now Newspack Blue in both the block inserters and the placeholders:

Screen Shot 2021-03-19 at 4 53 02 PM

Screen Shot 2021-03-19 at 4 52 55 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkoo dkoo merged commit a8caf8e into epic/phase-2 Mar 23, 2021
@dkoo dkoo deleted the refactor/use-material-icons branch March 23, 2021 15:26
@dkoo dkoo mentioned this pull request Mar 30, 2021
6 tasks
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants