Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syncing attributes to inner blocks #63

Closed
wants to merge 2 commits into from

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jun 2, 2021

All Submissions:

Changes proposed in this Pull Request:

Something must have changed in a recent Gutenberg release that broke the (admittedly hacky) method we were using to sync the parent Curated List block's attributes to its inner blocks. This PR updates the method to use updateBlockAttributes as documented for this purpose instead.

Closes #62.

How to test the changes in this Pull Request:

  1. On master or epic/phase-2, create a Curated List block and set to Specific Listings mode.
  2. Add several listings of any type.
  3. Select the Curated List container block and change its content-related attributes, especially "Show Excerpt", "Show Category", "Show Tags", "Show Featured Image", etc.
  4. Observe that the individual listings do not update to reflect the selected options.
  5. Check out this branch, repeat step 3, and this time confirm that the editor preview updates as expected and the listings are shown with the expected content on the front-end.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the bug Something isn't working label Jun 2, 2021
@dkoo dkoo requested a review from adekbadek June 2, 2021 01:53
@dkoo dkoo self-assigned this Jun 2, 2021
@dkoo dkoo changed the base branch from master to epic/phase-2 June 2, 2021 01:54
@dkoo dkoo marked this pull request as ready for review June 2, 2021 01:58
@dkoo dkoo closed this Jun 2, 2021
@dkoo
Copy link
Contributor Author

dkoo commented Jun 2, 2021

Closed in favor of #64 since the bug affects master as well.

@dkoo dkoo deleted the fix/attributes-sync branch June 2, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [Status] Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: individual listings in specific listings mode don't inherit parent Curated List attributes in editor
1 participant