Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errors and bugs related to WP 5.8 #83

Merged
merged 1 commit into from
Jul 5, 2021
Merged

fix: errors and bugs related to WP 5.8 #83

merged 1 commit into from
Jul 5, 2021

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jun 30, 2021 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

While testing another unrelated theme in WP 5.8, I discovered that Listings causes several errors and visual bugs in the new blocks-based Widgets screen. These changes should fix those issues.

How to test the changes in this Pull Request:

  1. Update WP to v5.8. The easiest way to do this is to install the WordPress Beta Tester plugin, go to Tools > Beta Testing, then set your site's update channel to "Bleeding Edge" then stream option to "Beta/RC only". Then go to Updates and update to a v5.8.x version.
  2. Go to Appearance > Widgets. On master observe several PHP and JS errors that prevent the screen from rendering at all. e.g.
PHP Notice:  Trying to get property 'labels' of non-object in /Users/dkoo/Local Sites/newspack/app/public/wp-content/plugins/newspack-listings/includes/class-newspack-listings-blocks.php on line 82
  1. Check out this branch and rebuild. Refresh the Widgets page. Now confirm that the screen loads as expected without errors coming from this plugin (you may still see other errors from other plugins and themes—a lot have conflicts with the new Widgets page! If the page still doesn't load try disabling other plugins until it does.).
  2. Add two Curated List blocks to a widget area such as the sidebar. Make one "query" mode and the other "specific listings" mode. Set query params, add specific listings, and change visual options from the defaults in both blocks. Confirm that all functionality works as expected in the widget editor. Save your widget changes.
  3. View the widget on the front-end and confirm that the Curated List blocks render as expected within the widget area.
  4. Also repeat steps 4-5 in a post or page and confirm that nothing has changed in these contexts.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the bug Something isn't working label Jun 30, 2021
@dkoo dkoo requested a review from a team June 30, 2021 23:38
@dkoo dkoo self-assigned this Jun 30, 2021
@dkoo dkoo merged commit 90da6c5 into master Jul 5, 2021
@dkoo dkoo deleted the fix/wp-5-8-errors branch July 5, 2021 15:46
matticbot pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 2.0.0-alpha.3 [skip ci]
eaed152 
# [2.0.0-alpha.3](v2.0.0-alpha.2...v2.0.0-alpha.3) (2021-07-06)

* v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81)

### Bug Fixes

* errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5))

### BREAKING CHANGES

* This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost.

To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
02fb7ea 
# [2.0.0](v1.2.2...v2.0.0) (2021-07-06)

* v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81)

### Bug Fixes

* errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5))

### BREAKING CHANGES

* This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost.

To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 19, 2021
@semantic-release-bot
chore(release): 1.0.0-alpha.1 [skip ci]
77f6a29 
# 1.0.0-alpha.1 (2021-07-19)

### Bug Fixes

* avoid meta sync update error ([#95](#95)) ([cab16aa](cab16aa))
* do not register post-specific sidebars in widgets page ([#93](#93)) ([7716775](7716775))
* editor errors with reusable blocks ([#89](#89)) ([fdc46d3](fdc46d3))
* errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5))
* force alpha rebuild ([acc2075](acc2075))
* minor bug fixes ([#21](#21)) ([5f90bc7](5f90bc7))
* missing condition for block appender in list container ([#74](#74)) ([2c49896](2c49896))
* syncing attributes from curated list block to inner blocks ([#64](#64)) ([cdbc0bb](cdbc0bb))
* use synced attributes for ListContainer directly ([#73](#73)) ([f8641a7](f8641a7))

### Features

* add block patterns ([#23](#23)) ([a273a40](a273a40))
* bump max number of items per list from 20 to 50 ([#97](#97)) ([009deab](009deab))
* initial post type and block setup ([#1](#1)) ([47dc0c1](47dc0c1))
* listing taxonomies and query mode ([#6](#6)) ([528e1e5](528e1e5))
* more block patterns (real estate, classified ads) ([#84](#84)) ([a51f5af](a51f5af))
* new Curated List block, block pattern, and map functionality ([#3](#3)) ([9be6e7e](9be6e7e))
* remove borders and padding in editor to match front-end styles ([#14](#14)) ([6c47a17](6c47a17))

* v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81)

### BREAKING CHANGES

* This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost.

To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@dkoo dkoo

Labels
bug Something isn't working released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @adekbadek