Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow editors to pull content #28

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

leogermani
Copy link
Contributor

Testing:

  • On master login to the admin dashboard as an editor
  • Confirm you don't see the Distributor menu item
  • Checkout this branch
  • Confirm you see the Distributor menu with one sub-item to pull content
  • Test pulling a post and confirm it works

@leogermani leogermani self-assigned this Dec 19, 2023
@leogermani leogermani requested a review from a team as a code owner December 19, 2023 14:11
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the rest of the plugin structure, the existence of this global.php file looks a bit off to me. Non-blocking suggestion: maybe namespace it like it's done everywhere else?

@leogermani
Copy link
Contributor Author

I just thought it was ok to have a file where we could drop these short snippets, but we can revisit this at any time

@leogermani leogermani merged commit 3021f7e into master Dec 19, 2023
3 checks passed
@miguelpeixe miguelpeixe deleted the feat/allow-editors-to-pull-content branch December 19, 2023 20:06
matticbot pushed a commit that referenced this pull request Dec 22, 2023
# [1.0.0-alpha.2](v1.0.0-alpha.1...v1.0.0-alpha.2) (2023-12-22)

### Bug Fixes

* dont sync authors terms ([#26](#26)) ([a4a788b](a4a788b))
* **newspack-ads:** parse targeting site url ([#22](#22)) ([acb84c1](acb84c1))

### Features

* allow editors to pull content ([#28](#28)) ([3021f7e](3021f7e))
* network donation events as reader data ([#8](#8)) ([9a114a4](9a114a4))
* sync user avatar ([#21](#21)) ([70e4c83](70e4c83))
* update authors on post update ([#29](#29)) ([25cb65f](25cb65f))
* update menu icon and position ([#18](#18)) ([11638b2](11638b2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 22, 2023
# 1.0.0 (2023-12-22)

### Bug Fixes

* adjust node_id check logic ([9ceb09f](9ceb09f))
* canonical url processing ([c9ee2c9](c9ee2c9))
* dont sync authors terms ([#26](#26)) ([a4a788b](a4a788b))
* failing CI jobs ([#11](#11)) ([c62248b](c62248b))
* **newspack-ads:** parse targeting site url ([#22](#22)) ([acb84c1](acb84c1))
* remove gam ad targeting ([#16](#16)) ([c47cb15](c47cb15))

### Features

* add circle ci config ([3f9d752](3f9d752))
* Add site role selection and unify menus ([bbc8eb5](bbc8eb5))
* add support to local Woo events ([1273ee1](1273ee1))
* **ads:** support network targeting key-val ([#13](#13)) ([37f677a](37f677a))
* allow editors to pull content ([#28](#28)) ([3021f7e](3021f7e))
* bump limit of events pulled by nodes from to 2 to 20 ([#7](#7)) ([c5fbdc5](c5fbdc5))
* network donation events as reader data ([#8](#8)) ([9a114a4](9a114a4))
* **node:** debug tools ([#12](#12)) ([07b5470](07b5470))
* refactor to symetric crypto ([1f55551](1f55551))
* sync author bio and meta ([#15](#15)) ([f60236d](f60236d))
* sync user avatar ([#21](#21)) ([70e4c83](70e4c83))
* update authors on post update ([#29](#29)) ([25cb65f](25cb65f))
* update menu icon and position ([#18](#18)) ([11638b2](11638b2))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants