fix(newspack-ads): remove gam ad targeting #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
approved these changes
Dec 1, 2023
matticbot
pushed a commit
that referenced
this pull request
Dec 1, 2023
# 1.0.0-alpha.1 (2023-12-01) ### Bug Fixes * adjust node_id check logic ([9ceb09f](9ceb09f)) * canonical url processing ([c9ee2c9](c9ee2c9)) * failing CI jobs ([#11](#11)) ([c62248b](c62248b)) * remove gam ad targeting ([#16](#16)) ([c47cb15](c47cb15)) ### Features * add circle ci config ([3f9d752](3f9d752)) * Add site role selection and unify menus ([bbc8eb5](bbc8eb5)) * add support to local Woo events ([1273ee1](1273ee1)) * **ads:** support network targeting key-val ([#13](#13)) ([37f677a](37f677a)) * bump limit of events pulled by nodes from to 2 to 20 ([#7](#7)) ([c5fbdc5](c5fbdc5)) * **node:** debug tools ([#12](#12)) ([07b5470](07b5470)) * refactor to symetric crypto ([1f55551](1f55551)) * sync author bio and meta ([#15](#15)) ([f60236d](f60236d))
|
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 22, 2023
# 1.0.0 (2023-12-22) ### Bug Fixes * adjust node_id check logic ([9ceb09f](9ceb09f)) * canonical url processing ([c9ee2c9](c9ee2c9)) * dont sync authors terms ([#26](#26)) ([a4a788b](a4a788b)) * failing CI jobs ([#11](#11)) ([c62248b](c62248b)) * **newspack-ads:** parse targeting site url ([#22](#22)) ([acb84c1](acb84c1)) * remove gam ad targeting ([#16](#16)) ([c47cb15](c47cb15)) ### Features * add circle ci config ([3f9d752](3f9d752)) * Add site role selection and unify menus ([bbc8eb5](bbc8eb5)) * add support to local Woo events ([1273ee1](1273ee1)) * **ads:** support network targeting key-val ([#13](#13)) ([37f677a](37f677a)) * allow editors to pull content ([#28](#28)) ([3021f7e](3021f7e)) * bump limit of events pulled by nodes from to 2 to 20 ([#7](#7)) ([c5fbdc5](c5fbdc5)) * network donation events as reader data ([#8](#8)) ([9a114a4](9a114a4)) * **node:** debug tools ([#12](#12)) ([07b5470](07b5470)) * refactor to symetric crypto ([1f55551](1f55551)) * sync author bio and meta ([#15](#15)) ([f60236d](f60236d)) * sync user avatar ([#21](#21)) ([70e4c83](70e4c83)) * update authors on post update ([#29](#29)) ([25cb65f](25cb65f)) * update menu icon and position ([#18](#18)) ([11638b2](11638b2))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary logic for
sitecustom targeting key-val is moving to Newspack Ads (Automattic/newspack-ads#770), so we no longer need to perform the ad slot targeting here.The integration should now only ensure that all the URLs are part of the inventory.
Testing