-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event queue debug #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new table is working great!
Non-blocking, but I'm not sure about the use of the term "queue" here. The webhook request doesn't behave like a queue. They are independent and process whenever they can, e.g., if there's a hiccup and the webhook request is scheduled to try again in a couple of minutes, a later request might run sooner. How about "Event history"?
Hmm it's not history because the have not been sent yet
or simply "Recent Events" and also change "queued" with "scheduled" in the paragraph there |
I like "Scheduled events" even if it still shows the most recent sent events. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🎉 This PR is included in version 1.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adds a debug section that shows the events that are scheduled to be sent from the Node to the Hub
Testing
Perform some actions in the Node, like registering with a new user, or editing a user profile in admin.
Go to Newspack Network > Node Settings and see the new "Events queue" section. Confirm the events are there, scheduled to be sent
Force some errors, by setting a wrong URL to the Hub, or making the Hub not accessible.
Perform a new action and wait for it to display errors
Note 1: Not adding a "Send now" button at this moment