fix: race condition when creating a Node #57
Merged
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
Newspack_Ads_GAM
andHub\Nodes
classes were hooking onsave_post
when a Node was created / updated.Depending on the order in which plugins were loaded, the GAM class would try to access the node metadata before it was created, because their hook was called earlier.
This PR fixes this race condition.
Instead of changing the priority of the
add_action
, I suggested that we created a dedicated new action, so we don't risk of making the same mistake again.