-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): added wp cli command - process pending requests #67
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
19b84b3
feat(node): new `wp np-network process` command
jaredrethman e42fdb2
docs: added available cli commands section
jaredrethman ca1a887
chore: remove \n
jaredrethman ba71a82
docs: added flags
jaredrethman 462bdd3
Merge remote-tracking branch 'origin/trunk' into feat/wpcli-process-p…
jaredrethman 3ad2767
fix: phpcs errors
jaredrethman b6d50a8
fix(cli): phpcs
jaredrethman efa1709
fix(cli): phpcs added return statement
jaredrethman f215367
fix: empty processed status and error on empty
jaredrethman 36049d4
feat(cli): added more informative stdout feedback
jaredrethman e9e96f3
fix: phpcs
jaredrethman 0bb37c4
feat: pr feedback, updated command name
jaredrethman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. Feel free to ignore. I think we were okay with the warning here. For large batches of events where some fail and some succeed, I would expect to see information about what failed and what succeeded.
Thinking about this some more, something like the following would be ideal IMO:
success - all events processed
warning - some events processed, some events not processed
error - no events processed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some solid suggestions there @chickenn00dle! I have implemented your suggestions, capture last error (i.e. the one that caused the error to be captured) and added some additional comments/docs etc 36049d4, all-in-all your suggestion adds a lot of value to the command, thank you 🤜 🤛
Success:
Warning: (hard to test)
Errors: