Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow social-link inner block #603

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The core/social-links block requires an unlisted inner block called core/social-link that must be allowed for the block to function properly.

Closes #595.

How to test the changes in this Pull Request:

  1. On the master branch, edit a newsletter and attempt to create Social Links
  2. Observe that the appender element is not visible and you are not able to add links
  3. Check out this branch, refresh the page and observe the block is now working as expected

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe requested a review from a team October 26, 2021 18:34
@miguelpeixe miguelpeixe self-assigned this Oct 26, 2021
@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Nov 1, 2021
@miguelpeixe miguelpeixe merged commit ab2f892 into master Nov 1, 2021
matticbot pushed a commit that referenced this pull request Nov 1, 2021
## [1.35.1-alpha.1](v1.35.0...v1.35.1-alpha.1) (2021-11-01)

### Bug Fixes

* allow social-link inner block ([#603](#603)) ([ab2f892](ab2f892))
* **mailchimp:** segment selection and saved segments ([#605](#605)) ([e0b62e3](e0b62e3))
* enable prompts on public newsletters ([7e2290b](7e2290b))
* merge color palette values ([#608](#608)) ([9ba2bae](9ba2bae))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.35.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 3, 2021
## [1.35.1](v1.35.0...v1.35.1) (2021-11-03)

### Bug Fixes

* allow social-link inner block ([#603](#603)) ([ab2f892](ab2f892))
* **mailchimp:** segment selection and saved segments ([#605](#605)) ([e0b62e3](e0b62e3))
* enable prompts on public newsletters ([7e2290b](7e2290b))
* merge color palette values ([#608](#608)) ([9ba2bae](9ba2bae))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 3, 2021
## [1.35.1](v1.35.0...v1.35.1) (2021-11-03)

### Bug Fixes

* allow social-link inner block ([#603](#603)) ([ab2f892](ab2f892))
* **mailchimp:** segment selection and saved segments ([#605](#605)) ([e0b62e3](e0b62e3))
* enable prompts on public newsletters ([7e2290b](7e2290b))
* merge color palette values ([#608](#608)) ([9ba2bae](9ba2bae))
@miguelpeixe miguelpeixe deleted the fix/social-links-inner-block branch May 24, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for icons in the Social Icons block
3 participants