feat: color palette adjustments #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
chickenn00dle
force-pushed
the
feat/add-newsletter-palette-update-functionality
branch
from
a973574
to
1e8c12e
Compare
chickenn00dle
force-pushed
the
feat/add-newsletter-palette-update-functionality
branch
from
1e8c12e
to
30c1581
Compare
adekbadek
approved these changes
Apr 26, 2024
| const PUBLIC_POST_ID_META = 'newspack_nl_public_post_id'; | ||
| const NEWSPACK_NEWSLETTERS_CPT = 'newspack_nl_cpt'; | ||
| const EMAIL_HTML_META = 'newspack_email_html'; | ||
| const NEWSPACK_NEWSLETTERS_PALETTE = 'newspack_newsletters_color_palette'; |
There was a problem hiding this comment.
Nit: just to be clear that the variable holds a meta key name and not "a color palette".
Suggested change
| const NEWSPACK_NEWSLETTERS_PALETTE = 'newspack_newsletters_color_palette'; | |
| const NEWSPACK_NEWSLETTERS_PALETTE_META_KEY = 'newspack_newsletters_color_palette'; |
There was a problem hiding this comment.
Fixed in 346714c
github-actions
bot
added
[Status] Approved
chickenn00dle
deleted the
feat/add-newsletter-palette-update-functionality
branch
|
🎉 This PR is included in version 2.15.0-hotfix-tracking-logfile-fatals-and-mc-interests.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 20, 2024
# [2.15.0-alpha.4](v2.15.0-alpha.3...v2.15.0-alpha.4) (2024-05-20) ### Bug Fixes * respect buttons alignment and sizing ([#1492](#1492)) ([0a63a5a](0a63a5a)) ### Features * **layouts:** save sender and audience in the layout ([#1461](#1461)) ([aec7bce](aec7bce)) * newsletters color palette adjustments ([#1487](#1487)) ([2b0ecac](2b0ecac)) * **ras-acc:** add helper method to identify premium lists ([#1502](#1502)) ([2473ea7](2473ea7))
|
🎉 This PR is included in version 2.15.0-alpha.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 28, 2024
# [2.15.0](v2.14.4...v2.15.0) (2024-05-28) ### Bug Fixes * bad auto-merge ([fdfe15f](fdfe15f)) * **newsletter-editor:** tag/segment selection ([2589d3a](2589d3a)) * respect buttons alignment and sizing ([#1492](#1492)) ([0a63a5a](0a63a5a)) ### Features * **layouts:** save sender and audience in the layout ([#1461](#1461)) ([aec7bce](aec7bce)) * newsletters color palette adjustments ([#1487](#1487)) ([2b0ecac](2b0ecac)) * notify site admin on campaign send failure ([#1434](#1434)) ([4e95283](4e95283)) * **ras-acc:** add helper method to identify premium lists ([#1502](#1502)) ([2473ea7](2473ea7))
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR is paired with the following Plugin PR: Automattic/newspack-plugin#3083
This makes the newsletter color palette a bit more flexible to work with by:
How to test the changes in this Pull Request:
These changes should not change any of the existing behavior of newsletters.
Other information: