Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix circleci build #610

Merged
merged 2 commits into from
Nov 1, 2021
Merged

chore: fix circleci build #610

merged 2 commits into from
Nov 1, 2021

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

As seen on Automattic/newspack-ads#214 and ab2f892, this PR changes the circle ci tasks PHP images from circleci to cimg.

How to test the changes in this Pull Request:

CI tasks must pass.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe requested a review from a team November 1, 2021 19:46
@miguelpeixe miguelpeixe self-assigned this Nov 1, 2021
@github-actions github-actions bot added [Status] Approved Ready to merge and removed [Status] Needs Review labels Nov 1, 2021
@miguelpeixe miguelpeixe merged commit bf3e7e6 into master Nov 1, 2021
@miguelpeixe miguelpeixe deleted the chore/fix-circle-build branch November 1, 2021 20:17
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.35.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants