Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand memberships performance tweaks to archives #3148

Merged
merged 1 commit into from
May 31, 2024

Conversation

claudiulodro
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Expands the performance improvements from #3136 to also work on archives. Memberships doesn't really do anything useful on archives except possibly display a "You need to purchase a membership to view this" message at the excerpt of some posts.

How to test the changes in this Pull Request:

  1. Have a site with Memberships set up. Visit a category/tag/author archive. Ensure things continue functioning as normal.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@claudiulodro claudiulodro added the [Status] Needs Review The issue or pull request needs to be reviewed label May 29, 2024
@claudiulodro claudiulodro requested a review from a team as a code owner May 29, 2024 22:39
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 31, 2024
@dkoo dkoo merged commit bdbdf1d into trunk May 31, 2024
9 checks passed
@dkoo dkoo deleted the feat/improve-archive-performance branch May 31, 2024 22:25
matticbot pushed a commit that referenced this pull request May 31, 2024
# [4.2.0-alpha.1](v4.1.0...v4.2.0-alpha.1) (2024-05-31)

### Bug Fixes

* **newsletters:** missing UTM params passing ([#3145](#3145)) ([0688fa0](0688fa0))
* **ras-setup:** redirect to init screen after setup ([#3142](#3142)) ([b86580b](b86580b))
* **ras:** handle RAS disabled in newsletters signup handling ([3d70a1d](3d70a1d))
* **ras:** prevent email address exposure via user login ([#3139](#3139)) ([9b534d3](9b534d3))
* **reader-revenue:** prevent sending duplicate receipt emails ([aa91890](aa91890))
* **tracking:** handling user role in pixel ([#3137](#3137)) ([a041764](a041764))

### Features

* **cli:** enable running the setup with a site import ([#3122](#3122)) ([c6cc10e](c6cc10e))
* expand memberships perf to archives ([#3148](#3148)) ([bdbdf1d](bdbdf1d))
* **memberships:** remove content restriction handling on the homepage ([b63a3fa](b63a3fa))
* update donation landing page ([#3109](#3109)) ([96218c1](96218c1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-epic-ia.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dkoo pushed a commit that referenced this pull request Jun 11, 2024
matticbot pushed a commit that referenced this pull request Jun 12, 2024
# [4.3.0](v4.2.0...v4.3.0) (2024-06-12)

### Bug Fixes

* **newsletters:** missing UTM params passing ([#3145](#3145)) ([0688fa0](0688fa0))
* **ras-setup:** redirect to init screen after setup ([#3142](#3142)) ([b86580b](b86580b))
* **ras:** handle RAS disabled in newsletters signup handling ([3d70a1d](3d70a1d))
* **ras:** prevent email address exposure via user login ([#3139](#3139)) ([9b534d3](9b534d3))
* **reader-revenue:** prevent sending duplicate receipt emails ([aa91890](aa91890))
* **tracking:** handling user role in pixel ([#3137](#3137)) ([a041764](a041764))

### Features

* **cli:** enable running the setup with a site import ([#3122](#3122)) ([c6cc10e](c6cc10e))
* expand memberships perf to archives ([#3148](#3148)) ([bdbdf1d](bdbdf1d))
* **memberships:** remove content restriction handling on the homepage ([b63a3fa](b63a3fa))
* update donation landing page ([#3109](#3109)) ([96218c1](96218c1))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants