fix(ras-setup): redirect to init screen after setup #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adekbadek
added
the
[Status] Needs Review
chickenn00dle
approved these changes
May 28, 2024
| setProgress( activationSteps.length + 1 ); // Plus one to account for the "Done!" step. | ||
| setProgressLabel( __( 'Done!', 'newspack-plugin' ) ); | ||
| setTimeout( () => { | ||
| setInFlight( false ); | ||
| // window.location = reader_activation_url; | ||
| window.location = reader_activation_url; |
There was a problem hiding this comment.
I would recommend using replace here so we remove the 'setup complete' page from history.
Suggested change
| window.location = reader_activation_url; | |
| window.location.replace( reader_activation_url ); |
Feel free to ignore the suggestion above, but if you do, I would at least change this to window.location.href:
Suggested change
| window.location = reader_activation_url; | |
| window.location.href = reader_activation_url; |
There was a problem hiding this comment.
Good idea! Added in 218eff7
github-actions
bot
added
[Status] Approved
|
🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 31, 2024
# [4.2.0-alpha.1](v4.1.0...v4.2.0-alpha.1) (2024-05-31) ### Bug Fixes * **newsletters:** missing UTM params passing ([#3145](#3145)) ([0688fa0](0688fa0)) * **ras-setup:** redirect to init screen after setup ([#3142](#3142)) ([b86580b](b86580b)) * **ras:** handle RAS disabled in newsletters signup handling ([3d70a1d](3d70a1d)) * **ras:** prevent email address exposure via user login ([#3139](#3139)) ([9b534d3](9b534d3)) * **reader-revenue:** prevent sending duplicate receipt emails ([aa91890](aa91890)) * **tracking:** handling user role in pixel ([#3137](#3137)) ([a041764](a041764)) ### Features * **cli:** enable running the setup with a site import ([#3122](#3122)) ([c6cc10e](c6cc10e)) * expand memberships perf to archives ([#3148](#3148)) ([bdbdf1d](bdbdf1d)) * **memberships:** remove content restriction handling on the homepage ([b63a3fa](b63a3fa)) * update donation landing page ([#3109](#3109)) ([96218c1](96218c1))
|
🎉 This PR is included in version 4.2.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.2.0-epic-ia.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dkoo
pushed a commit
that referenced
this pull request
Jun 11, 2024
matticbot
pushed a commit
that referenced
this pull request
Jun 12, 2024
# [4.3.0](v4.2.0...v4.3.0) (2024-06-12) ### Bug Fixes * **newsletters:** missing UTM params passing ([#3145](#3145)) ([0688fa0](0688fa0)) * **ras-setup:** redirect to init screen after setup ([#3142](#3142)) ([b86580b](b86580b)) * **ras:** handle RAS disabled in newsletters signup handling ([3d70a1d](3d70a1d)) * **ras:** prevent email address exposure via user login ([#3139](#3139)) ([9b534d3](9b534d3)) * **reader-revenue:** prevent sending duplicate receipt emails ([aa91890](aa91890)) * **tracking:** handling user role in pixel ([#3137](#3137)) ([a041764](a041764)) ### Features * **cli:** enable running the setup with a site import ([#3122](#3122)) ([c6cc10e](c6cc10e)) * expand memberships perf to archives ([#3148](#3148)) ([bdbdf1d](bdbdf1d)) * **memberships:** remove content restriction handling on the homepage ([b63a3fa](b63a3fa)) * update donation landing page ([#3109](#3109)) ([96218c1](96218c1))
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In RAS setup, skipping the Campaigns (#3051) does not redirect to the initial screen after setup is complete, and displays activation steps erroneously. This PR fixes that.
How to test the changes in this Pull Request:
trunk* Reset by running
wp option delete newspack_reader_activation_enabled newspack_popups_ras_prompts_last_updated _newspack_ras_skip_campaign_setupOther information: