fix: update newsletter scroll styles #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
added
the
[Status] Needs Review
github-actions
bot
added
[Status] Approved
|
Thanks @dkoo! |
dkoo
added a commit
that referenced
this pull request
Feb 1, 2024
…2895) * feat(ci): add epic/* release workflow and rename `master` to `trunk` * chore: point to dev version of newspack-scripts (REVERT BEFORE MERGING) * docs: update branch names in README * fix: revert unintentional branch name update for third-party repo * fix: update newsletter scroll appearance in Sign Up modal (#2897) * fix(ras): only sync spend total and last payment amounts for completed orders (#2886) * fix(ras): only sync spend total and last payment amounts for completed orders * fix: no need to manually add last order amount to total * fix: logic for updating upon subscription status change * fix: apply ex- status only for cancelled or expired subs * refactor: syntax fixes * fix: update newspack-scripts to release version --------- Co-authored-by: Laurel <laurel.fulford@automattic.com>
|
🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 8, 2024
# [3.1.0-alpha.1](v3.0.3...v3.1.0-alpha.1) (2024-02-08) ### Bug Fixes * **engagement-wizard:** handle error when retrieving subscription lists ([e85c108](e85c108)) * **ras:** only sync spend total and last payment amounts for completed orders ([#2886](#2886)) ([68aaf39](68aaf39)) * redirect to origin from magic link ([9f41947](9f41947)) * typescript errors ([dc27973](dc27973)) * TypeScript usage; add to CI ([#2884](#2884)) ([6f5e7a6](6f5e7a6)) * update newsletter scroll appearance in Sign Up modal ([#2897](#2897)) ([496723a](496723a)) ### Features * **ci:** add epic/* release workflow and rename `master` to `trunk` ([#2895](#2895)) ([ea02075](ea02075)), closes [#2897](#2897) [#2886](#2886) * **reader-revenue:** make NYP and Stripe Gateway optional ([#2866](#2866)) ([fcfa88c](fcfa88c)) * remove new tab default on image credits ([#2880](#2880)) ([3c996b1](3c996b1)) * **wc:** override cart, checkout, and my-account page templates ([#2893](#2893)) ([68b1836](68b1836))
|
🎉 This PR is included in version 3.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 20, 2024
# [3.1.0](v3.0.5...v3.1.0) (2024-02-20) ### Bug Fixes * add frequency tab options for donations, even when tiers are disabled ([#2930](#2930)) ([cb7eb7b](cb7eb7b)) * **categories:** fix pager urls ([#2913](#2913)) ([bb7e534](bb7e534)) * **categories:** fix pager urls ([#2913](#2913)) ([c851bb6](c851bb6)) * **engagement-wizard:** handle error when retrieving subscription lists ([e85c108](e85c108)) * **ras:** only sync spend total and last payment amounts for completed orders ([#2886](#2886)) ([68aaf39](68aaf39)) * redirect to origin from magic link ([9f41947](9f41947)) * typescript errors ([dc27973](dc27973)) * TypeScript usage; add to CI ([#2884](#2884)) ([6f5e7a6](6f5e7a6)) * update newsletter scroll appearance in Sign Up modal ([#2897](#2897)) ([496723a](496723a)) * update path to wide template file ([#2918](#2918)) ([fdd6b69](fdd6b69)) ### Features * **ci:** add epic/* release workflow and rename `master` to `trunk` ([#2895](#2895)) ([ea02075](ea02075)), closes [#2897](#2897) [#2886](#2886) * **reader-revenue:** make NYP and Stripe Gateway optional ([#2866](#2866)) ([fcfa88c](fcfa88c)) * remove new tab default on image credits ([#2880](#2880)) ([3c996b1](3c996b1)) * **wc:** override cart, checkout, and my-account page templates ([#2893](#2893)) ([68b1836](68b1836))
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR makes a small tweak to the Newsletter section of the RAS sign up modal, to remove the scrollbars when they're not needed. This specifically affects Windows users, or Mac users who have their scrollbars set to always display (which is not the default setting).
See 1200550061930446-as-1206456908157509
How to test the changes in this Pull Request:
npm run build.Other information: