fix: add option to display subscriptionless memberships

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR is to work with an edge case where readers can have WooCommerce Memberships with expiration dates but without subscriptions. Because Newspack hides the Memberships tab in My Account, there's no way for readers to get information about these memberships.

In this specific case, we don't want to create associated subscriptions for these memberships because they'll send out a bunch of renewal emails. Instead, we just want a way for readers to be able to see when their memberships are expiring, so they can proactively renew them.

See: 1200550061930446-as-1206901401819708

How to test the changes in this Pull Request:

I wrote these test steps as though you'd be using different browser sessions to act as the admin and reader, but you can also use the User Switching plugin.

1. Set up a test site with RAS set up, plus WooCommerce Memberships installed.
2. Create two membership plans:
   • Make a membership plan that is not associated with a subscription. Set it to grant access upon "manual assignment only", and set the membership length to have a "specific length" (this can be any value, though one week, month, year is probably more realistic to test).
   • Make a membership plan that is associated with a subscription. Set up a Checkout Button block that allows you to purchase the associated subscription.
3. Create a test reader.
4. Manually assign the test reader the non-suscription membership plan.
5. In an incognito window, log in as this reader in an incognito window/different browser, and go to My Account. Note that you have no way to view your Memberships -- there's no Membership tab, and if you go to Subscriptions, it says you don't have any.

6. Apply this PR and run npm run build.
7. As your WordPress Admin user, navigate to WP Admin > WooCommerce > Settings > Memberships, and scroll to the bottom; confirm you have a Reader Activation section, and a checkmark to show active Memberships that don't have associated Subscriptions. The checkmark should be unchecked.

9. Check this option, and click Save.
10. Back in your reader browser session, refresh the Subscriptions tab.
11. Confirm that the 'No Subscriptions' message is gone, and you also get an extra table listing your non-subscription Memberships product with its expiry date:

12. Still logged in as this reader, navigate to where you set up your Checkout Button block for your subscription membership product, and purchase it.
13. Navigate back to My Account - confirm that 'Subscriptions' still says just 'Subscriptions' (and not 'My Subscription' -- normally the plugin will override that and link directly to your subscription if you have just one).
14. Click on Subscriptions, and confirm you see your subscription listed, as well as the Memberships table:

15. From the Subscription tab, click the 'View' tab next to your Membership, then click 'Manage' in the left column.
16. Click 'Cancel' to cancel your Membership.

17. Confirm that the Subscriptions tab now just says 'My Subscription' (because you don't have any active unsubscription-related memberships, it should be back at the default behaviour).
18. As your Admin user, manually re-assign the non-sub Membership to your reader.
19. As your reader, refresh My Account; if you're still viewing the single Subscription detail, you might need to click out of that section and back to get to the main Subscriptions list view.
20. As the Admin user, navigate to WP Admin > WooCommerce > Settings > Memberships.
21. Uncheck "Display memberships that don't have active subscriptions on the My Account Subscriptions tab. " and click Save.
22. As your reader, refresh My Account and confirm the membership is gone again (to confirm it's still assigned, you can go to /my-account/members-area).

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[laurelfulford]

@thomasguillot @kevinzweerink This one's kind of "it is what it is" visually, but I'd appreciate your thoughts on hiding the 'Cancel' button from the main Memberships table. Normally it shows in the list, but it seemed like extra clutter, and it wasn't consistent with how the Subscriptions list looked, when both were displaying.

(I'd also appreciate any feedback on little things we can improve!).

[thomasguillot]

Can we hide the "next bill on" column since it's not applicable?

[laurelfulford]

Can we hide the "next bill on" column since it's not applicable?

@thomasguillot Oooo, good call! I just pushed an update -- here's what it looks like without:

[dkoo]

@laurelfulford works well and with very clean code! Just a few minor suggestions below.

Adding the extra option in WooCommerce settings makes sense, but in practice we usually try not to add our own options into the WooCommerce settings UI. I think we should try to reimplement this new setting in the Newspack > Reader Activation > Advanced Settings wizard page. I'm okay with doing this as a separate follow-up PR so it doesn't block this one, though.

[dkoo]

Nit: this is not currently throwing any errors for me, but it's something we've run into occasionally, so this is a good practice to get into the habit of:

Suggested change

	$memberships_info = wc_memberships_get_user_active_memberships( $customer_id );
	$memberships_info = \wc_memberships_get_user_active_memberships( $customer_id );

If you're working in a PHP file that has a namespace (as this one does), when calling any global function, it's a good idea to prefix it with \. This tells PHP to look for this function in the global namespace. If you don't include the \ prefix, then PHP will first look for the function in the current namespace and then fall back to global if it doesn't exist in the current namespace. I've seen instances where this can cause fatal errors, so adding the \ sidesteps that whole issue and also makes the code a little clearer in a namespaced file (even if it's not required to avoid errors like in this case).

The exception to this rule is internal PHP functions, so if you can find the function in the PHP manual, you don't need to specify a namespace (global or otherwise) for it. In my code editor internal PHP functions are helpfully highlighted in a different color than other functions:

You also don't need to prefix the function name when checking whether it exists (like function_exists) as this will check for the function in every namespace including the global one, unless you pass a specific namespace.

[laurelfulford]

TIL -- nice! I didn't realize the purpose of the \, I figured it had something to do with namespaced/not namespaced, but didn't realize what it actually did under the hood.

[laurelfulford]

Thanks for this, @dkoo! This was all very helpful!

I made the code corrections in 44698b9, and then took a swing at moving the option into the Reader Activation advanced settings in d130fae.

It should now appear with the other Membership settings there, and, when the Memberships plugin isn't enabled, it shouldn't appear:

(It's also off by default like the original, which my screenshot doesn't really convey!)

Just let me know if it'd be better to roll back this bit and focus on the original set of changes, or if there's anything else that looks amiss -- thanks!

[dkoo]

Thanks for the changes! Looks good and works well!

[matticbot]

🎉 This PR is included in version 3.6.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 3.7.0-alpha.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀