Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add woo team sync metadata (WIP) #3325

Merged
merged 3 commits into from
Aug 15, 2024
Merged

feat: add woo team sync metadata (WIP) #3325

merged 3 commits into from
Aug 15, 2024

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Aug 8, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Adds a new metadata field for the ESP sync containing the Woo Teams the user is part of - if any, and if the Teams for Memberships plugin is installed.

Note that a sync to ESP is not triggered when a user is granted a membership or is added to a team. This will be subject for another PR

How to test the changes in this Pull Request:

  1. Activate Teams for Memberships
  2. Create two teams
  3. Add a user to the two teams (teams need to be assigned to different membership plans)
  4. Log in as that user and perform an action that will trigger a sync - for example, subscribe to a newsletter or make a donation
  5. Confirm that a new field "Woo Team" was added to the contact in the ESP with the slugs of the teams the user is a part of.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani self-assigned this Aug 13, 2024
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 13, 2024
@leogermani leogermani marked this pull request as ready for review August 13, 2024 15:25
@leogermani leogermani requested a review from a team as a code owner August 13, 2024 15:25
adekbadek
adekbadek approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. One nit I've found is that after switching to this branch, I had to perform one additional step of enabling the new field in the RAS settings:

image

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 15, 2024
@leogermani leogermani merged commit e5cc5e3 into trunk Aug 15, 2024
9 checks passed
@leogermani leogermani deleted the feat/add-woo-team-sync-meta branch August 15, 2024 13:24
matticbot pushed a commit that referenced this pull request Aug 15, 2024
@semantic-release-bot
chore(release): 5.1.0-alpha.1 [skip ci]
0ec3bf2 
# [5.1.0-alpha.1](v5.0.1...v5.1.0-alpha.1) (2024-08-15)

### Bug Fixes

* **data-events:** gate interaction for registration form ([#3327](#3327)) ([eb06194](eb06194))
* **ras:** destroy sessions on account verification ([#3328](#3328)) ([ab6efeb](ab6efeb))

### Features

* add phpcs sniff for newsletter methods ([#3337](#3337)) ([15f237c](15f237c))
* add woo team sync metadata (WIP) ([#3325](#3325)) ([e5cc5e3](e5cc5e3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.3.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.3.0-hotfix-memberships-prop-exists.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adekbadek adekbadek mentioned this pull request Aug 21, 2024
Merged
6 tasks
matticbot pushed a commit that referenced this pull request Aug 26, 2024
@semantic-release-bot
chore(release): 5.3.0 [skip ci]
ef78b93 
# [5.3.0](v5.2.1...v5.3.0) (2024-08-26)

### Bug Fixes

* **data-events:** gate interaction for registration form ([#3327](#3327)) ([eb06194](eb06194))
* **ras:** destroy sessions on account verification ([#3328](#3328)) ([ab6efeb](ab6efeb))

### Features

* add phpcs sniff for newsletter methods ([#3337](#3337)) ([15f237c](15f237c))
* add woo team sync metadata (WIP) ([#3325](#3325)) ([e5cc5e3](e5cc5e3))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This was referenced Aug 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@leogermani leogermani

Labels
released on @alpha released on @hotfix/memberships-prop-exists released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @adekbadek