Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): clear RAS user tokens on logout #3451

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1208379852549386/f

This PR resolves an issue where persisted user tokens can prevent readers from logging in until the tokens expire (30 minutes) after logging out.

How to test the changes in this Pull Request:

  1. As a reader without a password, log in via otp using the auth modal
  2. Immediately sign out
  3. Without reloading, attempt to sign in again
  4. On epic/ras-acc you will get stuck at the first step of the auth modal. The continue button will cause the form to load for a second, then do nothing. On this branch, you should get another OTP email and be able to sign in again.
  5. Smoke test some other paths for the auth flow to ensure nothing else has broken.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle marked this pull request as ready for review September 30, 2024 20:00
@chickenn00dle chickenn00dle requested a review from a team as a code owner September 30, 2024 20:00
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Sep 30, 2024
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce the issue described in the PR while on the epic/ras-acc branch, but clearing the tokens on logout is a good practice.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 3, 2024
@chickenn00dle chickenn00dle merged commit 7b04880 into epic/ras-acc Oct 3, 2024
10 checks passed
@chickenn00dle chickenn00dle deleted the fix/clear-user-tokens-on-logout branch October 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ras-acc testing [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants