fix: handle zero cover fee percentage #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenn00dle
added
the
[Status] Needs Review
leogermani
reviewed
Oct 1, 2024
| // Just one decimal place, please. | ||
| $flat_percentage = (float) number_format( ( ( $total - $subtotal ) * 100 ) / $subtotal, 1 ); | ||
| $flat_percentage = 0; | ||
| if ( $subtotal > 0 ) { |
There was a problem hiding this comment.
very NIT: but since we're here, why not also check if this is actually a number?
There was a problem hiding this comment.
Sure thing! Done in 846bdc2
leogermani
approved these changes
Oct 1, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Oct 1, 2024
## [5.3.12](v5.3.11...v5.3.12) (2024-10-01) ### Bug Fixes * handle zero cover fee percentage ([#3452](#3452)) ([742b378](742b378))
|
🎉 This PR is included in version 5.3.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.4.0-alpha.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1200550061930446/1208449408463805/f
Addresses an issue where the logic for rendering cover fee percentage text causes a fatal when switching subscriptions via My Account.
How to test the changes in this Pull Request:
releaseyou will get a fatal. On this branch you will not.Bonus: Go through the normal checkout flow for a donation with cover fees to confirm nothing has broken.
Other information: