-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WPCOM as a proxy for Google OAuth2 flow #962
Conversation
TODO: The Google OAuth relies on WPCOM auth - the latter should be handled in the dashboard, too. Otherwise, a user will not see the Google OAuth option until they authenticate via WPCOM. Edit: this is more complicated, and I think the "connections" - Google & WPCOM - should be a separate view (wizard), to be implemented later. Added as an issue: #984 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid! Really good work! I like that you added unit tests, also! 💯
# [1.42.0-alpha.2](v1.42.0-alpha.1...v1.42.0-alpha.2) (2021-06-01) ### Features * use WPCOM as a proxy for Google OAuth2 flow ([#962](#962)) ([b95fcc0](b95fcc0))
🎉 This PR is included in version 1.42.0-alpha.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Changes how Google OAuth flow works to a proxy flow.
How to test the changes in this Pull Request:
NEWSPACK_GOOGLE_OAUTH_ENABLED
env variable of valuetrue
- this is effectively a feature flag that will enable us to test on production_newspack_google_oauth
user meta and revoke "Newspack" app access at https://myaccount.google.com/permissionsOther information: