Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump NPM version number for newspack-components #965

Merged
merged 1 commit into from
May 18, 2021

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented May 17, 2021

All Submissions:

Changes proposed in this Pull Request:

#952 added a new component to the newspack-components package which has since been published to NPM. This PR bumps the version number to match the published package.

  • 1.5.0 includes the new AutocompleteWithSuggestions component
  • 1.5.1 is no different, but was published as part of trying to fix build issues when importing the component to a different repo

Note that repos that import components from the NPM package and update to 1.5.X may need to explicitly run npm install --save @babel/runtime if that package isn't a first-class dependency, due to a bug described in this thread.

How to test the changes in this Pull Request:

No functional changes in this PR, so no testing required.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo requested a review from adekbadek May 17, 2021 21:16
@dkoo dkoo self-assigned this May 17, 2021
@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label May 17, 2021
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels May 18, 2021
@dkoo dkoo merged commit ba243d7 into master May 18, 2021
@dkoo dkoo deleted the chore/update-components-version branch May 18, 2021 16:53
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.40.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants