Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): commit changelog and npm files on release branch only #208

Merged
merged 1 commit into from
May 14, 2024

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Updates the release script so that package.json, package-lock.json, and CHANGELOG.md are not updated when releasing to a channel other than release. Committing these files on alpha release channel generates noise in the changelog (and is not needed there), and creates merge conflicts.

How to test the changes in this Pull Request:

Test according to "Testing locally" instructions in the README

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Committing these files on alpha generates a lot of conflicts and is not very helpful anyway.
@adekbadek adekbadek requested a review from a team as a code owner May 7, 2024 08:08
Copy link

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and lgtm 👍

@adekbadek adekbadek merged commit f296705 into trunk May 14, 2024
3 checks passed
@adekbadek adekbadek deleted the feat/commit-files-on-release-only branch May 14, 2024 07:13
@matticbot
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants