Fix props mutation causing a crash in a strict mode #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Props is read-only. This fix destructures props to a new variable where hasCreateAction can safely be nulled out if necessary.
adekbadek
changed the title
|
Improvement LGTM. |
matticbot
pushed a commit
that referenced
this pull request
Aug 25, 2020
# [1.2.0-alpha.1](v1.1.0...v1.2.0-alpha.1) (2020-08-25) ### Bug Fixes * a safer way of overwriting the prop ([#39](#39)) ([c86e555](c86e555)) * checkout --> checkout_with_workspace ([#34](#34)) ([8138a11](8138a11)) * install rsync as part of release job ([efa53fc](efa53fc)) * merge conflicts ([9a2ed5d](9a2ed5d)) * semantic release config ([2366839](2366839)) * semantic release config ([#29](#29)) ([e116c58](e116c58)) ### Features * settings use value instead of placeholder ([#36](#36)) ([7276c5d](7276c5d)) * update sponsors icon to Material Design ([#35](#35)) ([b2719bf](b2719bf))
|
🎉 This PR is included in version 1.2.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Aug 25, 2020
# [1.2.0](v1.1.0...v1.2.0) (2020-08-25) ### Bug Fixes * a safer way of overwriting the prop ([#39](#39)) ([c86e555](c86e555)) * checkout --> checkout_with_workspace ([#34](#34)) ([8138a11](8138a11)) * install rsync as part of release job ([efa53fc](efa53fc)) * merge conflicts ([9a2ed5d](9a2ed5d)) * semantic release config ([2366839](2366839)) * semantic release config ([#29](#29)) ([e116c58](e116c58)) ### Features * settings use value instead of placeholder ([#36](#36)) ([7276c5d](7276c5d)) * update sponsors icon to Material Design ([#35](#35)) ([b2719bf](b2719bf))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes an issue appearing when
SCRIPT_DEBUGis set. Props is read-only, so mutating it probably causes a crash in the stricter mode enforced bySCRIPT_DEBUG.How to test the changes in this Pull Request:
masterSCRIPT_DEBUGinwp-config.phpOther information: