Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update sponsors icon to Material Design #35

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Instead of using Dashicons, I've switched the Plugin icon Material's monetization_on.
Also fixed the casing for Sponsor Logo to match Featured Image (minor change).

Screenshot 2020-08-21 at 17 13 37

How to test the changes in this Pull Request:

  1. Check the wpadmin sidebar icon
  2. Same whilst adding a new sponsor
  3. Switch to this branch
  4. In wpadmin you should see the new icon and in the editor you houldn't see an icon after "Sponsor Settings"

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasguillot Changes look good, thanks! I don't think composer.lock should be part of this diff, though—can you untrack/remove?

@thomasguillot
Copy link
Contributor Author

@thomasguillot Changes look good, thanks! I don't think composer.lock should be part of this diff, though—can you untrack/remove?

Sorry, didn't even notice 🤦
Done in 5447100

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@thomasguillot thomasguillot merged commit b2719bf into master Aug 21, 2020
matticbot pushed a commit that referenced this pull request Aug 25, 2020
# [1.2.0-alpha.1](v1.1.0...v1.2.0-alpha.1) (2020-08-25)

### Bug Fixes

* a safer way of overwriting the prop ([#39](#39)) ([c86e555](c86e555))
* checkout --> checkout_with_workspace ([#34](#34)) ([8138a11](8138a11))
* install rsync as part of release job ([efa53fc](efa53fc))
* merge conflicts ([9a2ed5d](9a2ed5d))
* semantic release config ([2366839](2366839))
* semantic release config ([#29](#29)) ([e116c58](e116c58))

### Features

* settings use value instead of placeholder ([#36](#36)) ([7276c5d](7276c5d))
* update sponsors icon to Material Design ([#35](#35)) ([b2719bf](b2719bf))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 25, 2020
# [1.2.0](v1.1.0...v1.2.0) (2020-08-25)

### Bug Fixes

* a safer way of overwriting the prop ([#39](#39)) ([c86e555](c86e555))
* checkout --> checkout_with_workspace ([#34](#34)) ([8138a11](8138a11))
* install rsync as part of release job ([efa53fc](efa53fc))
* merge conflicts ([9a2ed5d](9a2ed5d))
* semantic release config ([2366839](2366839))
* semantic release config ([#29](#29)) ([e116c58](e116c58))

### Features

* settings use value instead of placeholder ([#36](#36)) ([7276c5d](7276c5d))
* update sponsors icon to Material Design ([#35](#35)) ([b2719bf](b2719bf))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants