Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/ad suppression #62

Merged
merged 4 commits into from
Sep 16, 2021
Merged

feat/ad suppression #62

merged 4 commits into from
Sep 16, 2021

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Sep 13, 2021 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #8.

I've removed a fragment of code in 04fd88a since in my testing these dequeued assets were already not-enqueued by the respective plugins. Let me know if I've missed something here, @dkoo

How to test the changes in this Pull Request:

  1. Switch to feat/per-post-suppression-filter branch of Newspack Ads
  2. View a sponsored post, observe no ads are served
  3. View a regular post, observe ads are served

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek
feat: remove unused code
04fd88a 
These block assets will not be loaded for this CPT anyway
@adekbadek adekbadek requested a review from a team September 13, 2021 15:09
@adekbadek adekbadek mentioned this pull request Sep 13, 2021
Closed
@adekbadek adekbadek requested a review from dkoo September 13, 2021 15:10
dkoo
dkoo approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, thanks! Also didn't see any negative effects from not dequeuing the other plugin editor assets in 04fd88a.

@adekbadek adekbadek merged commit ac533c5 into master Sep 16, 2021
@adekbadek adekbadek deleted the feat/ad-suppression branch September 16, 2021 12:28
This was referenced Sep 16, 2021
Closed
Merged
matticbot pushed a commit that referenced this pull request Sep 21, 2021
@semantic-release-bot
chore(release): 1.6.0-alpha.1 [skip ci]
96f9687 
# [1.6.0-alpha.1](v1.5.0...v1.6.0-alpha.1) (2021-09-21)

### Bug Fixes

* ad suppression tweak ([c555e57](c555e57))

### Features

* suppress ads on sponsored posts ([#62](#62)) ([ac533c5](ac533c5))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Sep 21, 2021
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
6ebb893 
# [1.6.0](v1.5.0...v1.6.0) (2021-09-21)

### Bug Fixes

* ad suppression tweak ([c555e57](c555e57))

### Features

* suppress ads on sponsored posts ([#62](#62)) ([ac533c5](ac533c5))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tmmbecker tmmbecker mentioned this pull request Sep 22, 2021
Closed
@dkoo dkoo mentioned this pull request Sep 23, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ad supression
3 participants
@adekbadek @matticbot @dkoo