feat: add a global setting to suppress ads on sponsored posts #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurelfulford
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
This works as described for me! 👍
I had an ad in the global 'below header' position; when I applied this PR, it started displaying on my sponsored post, and when I checked "Suppress Ads" under the Sponsors settings, it stopped showing up on the sponsored post.
matticbot
pushed a commit
that referenced
this pull request
Sep 24, 2021
# [1.7.0-alpha.1](v1.6.0...v1.7.0-alpha.1) (2021-09-24) ### Features * add a global setting to suppress ads on sponsored posts ([#68](#68)) ([ce45916](ce45916))
|
🎉 This PR is included in version 1.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Sep 24, 2021
# [1.7.0](v1.6.0...v1.7.0) (2021-09-24) ### Features * add a global setting to suppress ads on sponsored posts ([#68](#68)) ([ce45916](ce45916))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Partially reverts the behavior from #62, which automatically suppresses all ads for all sponsored posts. This PR adds a new toggle option in plugin settings to do so (disabled by default), restoring the prior behavior but allowing publishers to opt into the new suppression.
Closes #67.
How to test the changes in this Pull Request:
master, publish a post with at least one sponsor and ensure at least one ad is displayed in a global position and/or block or widget.
### Other information: