-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wp5.9): taxonomy panel filter #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to have a more technical set of eyes check over this as well, but in my testing this PR fixed the issue and allowed me to load the editor and add/edit categories and tags using the 5.9 RC 2.
I also rolled my test site back to 5.8.3, I could still edit a sponsor and change the categories and tags with no issue. So it all looks good from a functional perspective! :)
The changes are pretty light from a logical perspective (it removes code instead of adding any), so I think we're good! |
🎉 This PR is included in version 1.8.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Looks like the props passed to the
editor.PostTaxonomyType
filter have changed in WP 5.9. It no longer passes ataxonomy
prop containing info about the taxonomy, such as whether it's hierarchical or its human-readable labels. However, it does still pass theslug
prop, which we can still use to determine whether the panel being rendered is for Categories or Tags. Relying on thisslug
prop alone should fix errors in WP 5.9 as well as maintain backwards compatibility with WP 5.8 and earlier.Unrelated, but also adds the missing
CHANGELOG.md
file that will be needed for the new post-release CI job implemented in #141.Fixes #148.
How to test the changes in this Pull Request:
master
, edit a sponsor and attempt to expand the Categories or Tags sidebar panels.Other information: