-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render small-caps font variant #1611
Open
samizdatco
wants to merge
7
commits into
Automattic:master
Choose a base branch
from
samizdatco:font-variant-css-2.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 24, 2020
-
render small-caps font variant
- pango has a PANGO_VARIANT_SMALL_CAPS variant that can be added to the font description, but setting it doesn't cause text to be rendered in small-caps, even if the font supports it - adding the appropriate opentype features to the layout's attributes list will use the font's small-caps glyphs if it provides them
Configuration menu - View commit details
-
Copy full SHA for 48059a5 - Browse repository at this point
Copy the full SHA 48059a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56260c7 - Browse repository at this point
Copy the full SHA 56260c7View commit details
Commits on Jun 25, 2020
-
added textAttributes field to state struct
- the font-variant state will get out of sync with the fontDescription across context-saves & restores unless we keep a copy of the PangoAttrList around
Configuration menu - View commit details
-
Copy full SHA for ed7d4a1 - Browse repository at this point
Copy the full SHA ed7d4a1View commit details
Commits on Jun 26, 2020
-
only set opentype features on sufficiently new versions of pango
- the pango NEWS file suggests 1.37.1 was where the `pango_attr_font_features_new` call was added...
Configuration menu - View commit details
-
Copy full SHA for 4d205f7 - Browse repository at this point
Copy the full SHA 4d205f7View commit details -
skip the small-caps variant test on windows
- it can be enabled if/when the pango version is updated
Configuration menu - View commit details
-
Copy full SHA for 7df005d - Browse repository at this point
Copy the full SHA 7df005dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1082954 - Browse repository at this point
Copy the full SHA 1082954View commit details -
Configuration menu - View commit details
-
Copy full SHA for c99281c - Browse repository at this point
Copy the full SHA c99281cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.