Add ctx.getTransform() and ctx.setTransform(DOMMatrix) methods #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on currentTransform getter
Based on currentTransform setter
zbjornson
approved these changes
Apr 20, 2021
pouretrebelle
added a commit
to pouretrebelle/jigsaws
that referenced
this pull request
May 1, 2021
In some sketches we create temporary canvases for layering and transforms, but on the server-side we can't reference document. This passes in a createCanvas function which uses document on the client side and node-canvas on the server side. N.B. This is still causing errors on sketches that have multiple canvases because c.getTransform isn't implemented in v2.7.0 if node-canvas. This was fixed a week ago (Automattic/node-canvas#1769) but a new version of the lib hasn't been released yet. I won't merge this until the package upgrade.
5 tasks
pouretrebelle
added a commit
to pouretrebelle/jigsaws
that referenced
this pull request
May 17, 2021
This includes the context.getTransform method which is needed in the preview lambda See: - Automattic/node-canvas#1769 - https://github.com/Automattic/node-canvas/blob/HEAD/CHANGELOG.md#280
pouretrebelle
added a commit
to pouretrebelle/jigsaws
that referenced
this pull request
Jun 27, 2021
In some sketches we create temporary canvases for layering and transforms, but on the server-side we can't reference document. This passes in a createCanvas function which uses document on the client side and node-canvas on the server side. N.B. This is still causing errors on sketches that have multiple canvases because c.getTransform isn't implemented in v2.7.0 if node-canvas. This was fixed a week ago (Automattic/node-canvas#1769) but a new version of the lib hasn't been released yet. I won't merge this until the package upgrade.
pouretrebelle
added a commit
to pouretrebelle/jigsaws
that referenced
this pull request
Jun 27, 2021
This includes the context.getTransform method which is needed in the preview lambda See: - Automattic/node-canvas#1769 - https://github.com/Automattic/node-canvas/blob/HEAD/CHANGELOG.md#280
pouretrebelle
added a commit
to pouretrebelle/jigsaws
that referenced
this pull request
Jun 27, 2021
In some sketches we create temporary canvases for layering and transforms, but on the server-side we can't reference document. This passes in a createCanvas function which uses document on the client side and node-canvas on the server side. N.B. This is still causing errors on sketches that have multiple canvases because c.getTransform isn't implemented in v2.7.0 if node-canvas. This was fixed a week ago (Automattic/node-canvas#1769) but a new version of the lib hasn't been released yet. I won't merge this until the package upgrade.
pouretrebelle
added a commit
to pouretrebelle/jigsaws
that referenced
this pull request
Jun 27, 2021
This includes the context.getTransform method which is needed in the preview lambda See: - Automattic/node-canvas#1769 - https://github.com/Automattic/node-canvas/blob/HEAD/CHANGELOG.md#280
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1642
Added getTransform() NAN_METHOD
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/getTransform
Added setTransform(matrix) overload
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/setTransform
(before that PR,
setTransformwas just an alias forctx.transform)