Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add string tags for browser polyglot classes #2214

Merged
merged 2 commits into from
Apr 17, 2023
Merged

add string tags for browser polyglot classes #2214

merged 2 commits into from
Apr 17, 2023

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Mar 20, 2023

Thanks for contributing!

  • Have you updated CHANGELOG.md?

Fixes #1646

@brettz9 brettz9 changed the title add string tags for ImageData and CanvasGradient add string tags for HTMLCanvasElement, ImageData and CanvasGradient Mar 20, 2023
@brettz9 brettz9 changed the title add string tags for HTMLCanvasElement, ImageData and CanvasGradient add string tags for browser polyglot classes Mar 20, 2023
@brettz9 brettz9 force-pushed the string-tags branch 2 times, most recently from 0caee43 to c456cad Compare March 20, 2023 15:45
@brettz9
Copy link
Contributor Author

brettz9 commented Apr 7, 2023

Anything else I can do for this?

@brettz9 brettz9 mentioned this pull request Apr 14, 2023
Closed
zbjornson
zbjornson approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you and sorry for the delay.

@zbjornson zbjornson merged commit 5902219 into Automattic:master Apr 17, 2023
phipla added a commit to e-cervo/node-canvas that referenced this pull request Sep 7, 2023
@phipla
Merge commit 'adf73ee39e2676b5c67b02bef5742b941033495c'
54f38c4 
* commit 'adf73ee39e2676b5c67b02bef5742b941033495c':
  Add node 20 to CI
  Upgrade GitHub Actions to use checkout@v3 (Automattic#2213)
  add string tags for browser polyglot classes (Automattic#2214)
  src: refactor and apply fixes
  v2.11.2
  fix not compiling on certain windows versions
  v2.11.1
  move ctx.font string to the state struct

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbjornson zbjornson zbjornson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageData not stringifying consistently on Node 14.7
2 participants
@brettz9 @zbjornson