-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for older versions of Node.js #2310
Conversation
I had to fix this error in another package recently by adding this before
|
macOS test failures are fixed, but getting a strange error on Windows with Node.js 20:
I don't think it's related to the changes here though, just that we are now testing on Node.js 20. We could allow failures for Windows/Node.js 20 for now? Or if you have any ideas on how to fix it @chearon? I don't have access to a windows machine myself 🙈 so it's going to be hard for me to debug... |
I think that this is the issue: It seems like it might be fixed with this PR: Which hopefully lands in the next Node.js 20.x release. Removing the 20.x test for Windows in the meantime. Also, I think that we should make sure that this project is included in the node citgm so that new Node.js releases gets tested against Canvas. In that case this regression would have been caught... Generally, I think that this approach (that is, test on lowest supported versions in our CI, and be included in CITGM to test latest Node.js version) is the best approach for larger projects like this, since I think that it's more likely that we accidentally introduce code that only works on newer versions of Node.js than our lowest supported, rather than Node.js introducing a breaking change... |
Part of breaking changes discussed in #2232, this changes to align with LTS-supported Node.js versions
This changes the minimum supported versions of Node.js:
16 and earlier = unsupported
17 = unsupported
18 = supported from 18.12.0 (LTS)
19 = unsupported
20 = supported from 20.9.0 (LTS)
21 and later = not tested, but should work
Have you updated CHANGELOG.md?