Allow alternate or properly escaped quotes *within* font-family names #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chearon
reviewed
Jul 7, 2024
chearon
approved these changes
Jul 7, 2024
|
Oops... I squashed and moved the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with font names that themselves contain quotes. This appears to be legal (or at least perfectly working) in the browser implementations, and after this fix Pango renders the correct font as well.
Importantly, font names are now split into an array, trimmed of quotes, unescaped, and joined back. This may have unexpected consequences beyond existing test cases, but I haven't come up with any.