fix TextMetrics type to include alphabeticBaseline, emHeightAscent, and emHeightDescent properties
#2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musou1500
changed the title
actualBoundingBoxLeft, actualBoundingBoxRight, fontBoundingBoxAscent, and fontBoundingBoxDescent propertiesalphabeticBaseline, emHeightAscent, and emHeightDescent properties
|
|
|
Looks good, thanks. I'm going to squash the commits and then move the changelog item to 3.0.0 since we haven't released it yet. Edit: and fix conflicts
I don't think Pango exposes what we'd need for those 2 properties. You'd need to know the first font that matched based on the |
chearon
force-pushed
the
add-text-metrics-props
branch
from
5902a57
to
45feb57
Compare
chearon
approved these changes
Aug 11, 2024
chearon
force-pushed
the
add-text-metrics-props
branch
from
45feb57
to
0d39df5
Compare
update CHANGELOG fix changelog
chearon
force-pushed
the
add-text-metrics-props
branch
from
0d39df5
to
e96b4eb
Compare
chearon
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!