Fixed exceptions on some queries types. #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed exception for new one
|
This PR is quite old, some ideas here have already been implemented and others, namely better wrapping of exceptions has been implemented in #33 now. (I did this because with the extensive changes since this PR merging would have been somewhat painful.) Thanks for the ideas here I'm going to close this PR in favor of the other one. |
xyu
added a commit
that referenced
this pull request
Jul 26, 2019
ThriftSQL v0.3.0 - Added - Ability to send Impala queries with usernames - Added - Default usernames to help limit invalid configurations - Added - Automatically closing query handles after all results are read - Added - Canceling queries on the server when timeouts are reached - Upgraded - Libraries to `Thrift@0.12.0`, `Hive@1.1.0`, `Impala@2.12.0` - Improved - Switched to a different classmap generator to get rid of a needless monkey patch of Beeswax service interface - Improved - Better wrapping of underlying exceptions to ease debugging (Props @Napas / #15) - Improved - Reduced size of PHP namespace and reorder them to better avoid collisions - Improved - Strip down the distribution PHAR and removed extraneous artifacts from Packagist - Improved - A better build and contribution process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Hive query failure on temporary function creation or add jar queries.