-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcripts: Display speaker info #2665
Conversation
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
builder.text = parseCueText(id, markup, styles); | ||
// parseCueText strips tags like TAG_VOICE "v" and set it on the cue text. This sets original markup wih tags in cue to allow extracting it in the application. | ||
builder.markup = markup; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cue.text
for vtt format parser strips out tags like TAG_VOICE "v" without setting it on the cue. This sets original markup with tags on the cue to allow extracting any tag in the application in 7548a3f.
I copied original source code for WebvttCueParser
and Cue
to make the change as the classes were final and could not be subclassed. Curious to know if there's a better way to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you report the issue in the media
repository? Hopefully they can add needed APIs and we can remove copied classes in the future. If they agree that this is something they could add we could make a PR to their repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked here: androidx/media#1632
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked well and look amazing.
.../src/main/java/au/com/shiftyjelly/pocketcasts/player/view/transcripts/TranscriptViewModel.kt
Outdated
Show resolved
Hide resolved
...yer/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/transcripts/TranscriptFilter.kt
Show resolved
Hide resolved
I'm reverting support for speaker info in VTT transcripts. I'm having issues including library class duplicates in the release apk in Also, including library class duplicates may cause issues in code maintenance. I'll try supporting speaker info in VTT transcripts separately. |
Description
This displays speaker info for transcripts.
Testing Instructions
Cautionary Tales
)TranscriptsManagerImpl.supportedFormats
at line 22Build your Saas
)Screenshots or Screencast
Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApply
to automatically apply formatting/linting)All strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.I have tested any UI changes...
with different themeswith a landscape orientationwith the device set to have a large display and font sizefor accessibility with TalkBack