PC-I182: Change Text When Upgrading Account From 'Account Created' to 'Account Upgraded' #512
Conversation
… 'Account Upgraded'
There was a problem hiding this comment.
This looks good and works well. Thanks for the contribution @owenlejeune ! 🙇
The only question I have is about where the translations came from. We use glotpress to get human-translated versions of our strings imported into Pocket Casts. Did you get these translations from something like Google Translate and add them manually? If so, I really appreciate you going to that effort, but let's remove all but the English version of the String from this PR and let GlotPress handle the translations for us.
… 'Account Upgraded'
|
@mchowning My bad! I wasn't sure what the process for adding translations was so I added them in myself, but I've removed them now and just let the entry in the default strings file. |
No worries, we need to document this better. Thanks for the update. |
Description
Change text when upgrading from free to premium from 'Account Created' to 'Account Upgraded'
Fixes #182
Testing Instructions
Screenshots or Screencast