Add setting toggle for lock screen scrubber

podcasts/Analytics/AnalyticsEvent.swift

@@ -487,6 +487,7 @@ enum AnalyticsEvent: String {
     case settingsGeneralSkipBackChanged
     case settingsGeneralKeepScreenAwakeToggled
     case settingsGeneralOpenPlayerAutomaticallyToggled
+    case settingsGeneralDisableLockScreenScrubberToggled
     case settingsGeneralIntelligentPlaybackToggled
     case settingsGeneralPlayUpNextOnTapToggled
     case settingsGeneralRemoteSkipsChaptersToggled

podcasts/Constants.swift

@@ -170,6 +170,8 @@ struct Constants {
         static let sleepTimerFinishedDate = "sleepTimerFinishedDate"
         static let sleepTimerSetting = "sleepTimerSetting"
 
+        static let isLockScreenScrubbingDisabled = "IsLockScreenScrubbingDisabled"
+
         enum headphones {
             static let previousAction = SettingValue("headphones.previousAction",
                                                       defaultValue: HeadphoneControlAction.skipBack)

podcasts/GeneralSettingsViewController.swift

@@ -10,8 +10,8 @@ class GeneralSettingsViewController: PCViewController, UITableViewDelegate, UITa
 
     let debounce = Debounce(delay: Constants.defaultDebounceTime)
 
-    private enum TableRow { case skipForward, skipBack, keepScreenAwake, openPlayer, intelligentPlaybackResumption, defaultRowAction, extraMediaActions, defaultAddToUpNextSwipe, defaultGrouping, defaultArchive, playUpNextOnTap, legacyBluetooth, multiSelectGesture, openLinksInBrowser, publishChapterTitles, autoplay, autoRestartSleepTimer, shakeToRestartSleepTimer }
-    private var tableData: [[TableRow]] = [[.defaultRowAction, .defaultGrouping, .defaultArchive, .defaultAddToUpNextSwipe, .openLinksInBrowser], [.skipForward, .skipBack, .keepScreenAwake, .openPlayer, .intelligentPlaybackResumption], [.autoRestartSleepTimer], [.shakeToRestartSleepTimer], [.playUpNextOnTap], [.extraMediaActions], [.legacyBluetooth], [.multiSelectGesture], [.publishChapterTitles], [.autoplay]]
+    private enum TableRow { case skipForward, skipBack, keepScreenAwake, openPlayer, intelligentPlaybackResumption, defaultRowAction, extraMediaActions, defaultAddToUpNextSwipe, defaultGrouping, defaultArchive, playUpNextOnTap, legacyBluetooth, multiSelectGesture, openLinksInBrowser, publishChapterTitles, autoplay, autoRestartSleepTimer, shakeToRestartSleepTimer, isLockScreenScrubberDisabled }
+    private var tableData: [[TableRow]] = [[.defaultRowAction, .defaultGrouping, .defaultArchive, .defaultAddToUpNextSwipe, .openLinksInBrowser], [.skipForward, .skipBack, .keepScreenAwake, .openPlayer, .isLockScreenScrubberDisabled, .intelligentPlaybackResumption], [.autoRestartSleepTimer], [.shakeToRestartSleepTimer], [.playUpNextOnTap], [.extraMediaActions], [.legacyBluetooth], [.multiSelectGesture], [.publishChapterTitles], [.autoplay]]
 
     @IBOutlet var settingsTable: UITableView! {
         didSet {
@@ -277,6 +277,16 @@ class GeneralSettingsViewController: PCViewController, UITableViewDelegate, UITa
             cell.cellSwitch.removeTarget(self, action: nil, for: .valueChanged)
             cell.cellSwitch.addTarget(self, action: #selector(shakeToRestartSleepTimerToggled(_:)), for: .valueChanged)
 
+            return cell
+        case .isLockScreenScrubberDisabled:
+            let cell = tableView.dequeueReusableCell(withIdentifier: switchCellId, for: indexPath) as! SwitchCell
+
+            cell.cellLabel.text = L10n.settingsGeneralLockScreenDisabled
+            cell.cellSwitch.isOn = !Settings.isLockScreenScrubbingDisabled
+
+            cell.cellSwitch.removeTarget(self, action: nil, for: .valueChanged)
+            cell.cellSwitch.addTarget(self, action: #selector(disableLockScreenScrubberToggled(_:)), for: .valueChanged)
+
             return cell
         }
     }
@@ -541,6 +551,12 @@ class GeneralSettingsViewController: PCViewController, UITableViewDelegate, UITa
         Settings.trackValueToggled(.settingsGeneralShakeToResetSleepTimerToggled, enabled: sender.isOn)
     }
 
+    @objc private func disableLockScreenScrubberToggled(_ sender: UISwitch) {
+        Settings.isLockScreenScrubbingDisabled = !sender.isOn
+
+        Settings.trackValueToggled(.settingsGeneralDisableLockScreenScrubberToggled, enabled: !sender.isOn)
+    }
+
     override var preferredStatusBarStyle: UIStatusBarStyle {
         AppTheme.defaultStatusBarStyle()
     }

podcasts/Settings.swift

@@ -9,6 +9,15 @@ import PocketCastsUtils
 
 class Settings: NSObject {
 
+    static var isLockScreenScrubbingDisabled: Bool {
+        set {
+            UserDefaults.standard.set(newValue, forKey: Constants.UserDefaults.openLinksInExternalBrowser)
+        }
+        get {
+            return UserDefaults.standard.bool(forKey: Constants.UserDefaults.openLinksInExternalBrowser)
+        }
+    }
+
     static var openLinks: Bool {
         set {
             if FeatureFlag.newSettingsStorage.enabled {

podcasts/en.lproj/Localizable.strings

@@ -2515,6 +2515,9 @@
 /* Subtitle explaining the feature that adjusts the playback position when resuming. */
 "settings_general_smart_playback_subtitle" = "If on, Pocket Casts will go back a little in episodes you resume so you can catch up more comfortably.";
 
+/* Setting toggle to enable the feature that disables the lock screen scrubber. */
+"settings_general_lock_screen_disabled" = "Lock Screen Scrubbing";
+
 /* Setting option to choose how to handle swiping to add something to the queue. */
 "settings_general_up_next_swipe" = "Up Next Swipe";