Remove new show notes endpoint FF #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioEstevao
added
the
[Type] Tech Debt
Generated by 🚫 Danger |
SergioEstevao
requested review from
danielebogo and
leandroalonso
and removed request for
a team
danielebogo
approved these changes
Dec 11, 2024
Sure thing, if Android is not using it I think we can remove it for sure |
SergioEstevao
commented
Dec 11, 2024
| @@ -164,8 +161,6 @@ public enum FeatureFlag: String, CaseIterable { | |||
| false | |||
| case .endOfYear: | |||
| false | |||
| case .newShowNotesEndpoint: | |||
| false | |||
There was a problem hiding this comment.
@danielebogo Just realized that we cannot remove the remote FF from Firebase, because of the above.
The default value is set to false so the older version where this was activated because of the remote FF will have the functionality disabled because the default value on the code is a false.
Am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: #2509 |
|:---:|
Fixes #2528
Removes the FF for using the new show notes endpoint
To test
Checklist
CHANGELOG.mdif necessary.