Playback 2024: Image share dimensions #2530

bjtitus · 2024-12-10T16:18:54Z

Fixes an issue with Instagram sharing where the image is cropped, cutting off the branding image at the bottom.

This changes the aspect ratio of the shared image to 9:16 for ALL sharing destinations.

InstagramShare2.mov

To test

Open Playback 2024 from Profile
Tap the "Share this story" button
Share to Instagram and select different options (mainly Story to verify the cropping)
Verify that the full shared image is shown and the Pocket Casts logo is not cut off at the bottom

I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
I have considered adding unit tests for my changes.
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

Instagram will crop images not in a 9:16 ratio

dangermattic · 2024-12-10T16:19:35Z

	1 Warning
⚠️	This PR is assigned to the milestone 7.78.1. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

leandroalonso

✅ Tested on Instagram
✅ Tested on Facebook
✅ Tested on Tumblr

Change shareable image dimensions to 9:16

a4a1725

Instagram will crop images not in a 9:16 ratio

bjtitus requested a review from a team as a code owner December 10, 2024 16:18

bjtitus requested review from leandroalonso and removed request for a team December 10, 2024 16:18

bjtitus added this to the 7.78.1 milestone Dec 10, 2024

bjtitus added the [Project] End of Year 2024 End of Year project for 2024 label Dec 10, 2024

leandroalonso approved these changes Dec 10, 2024

View reviewed changes

bjtitus merged commit bdf99e8 into release/7.78.1 Dec 10, 2024
5 of 8 checks passed

bjtitus deleted the bjtitus/playback-2024/image-share-dimensions branch December 10, 2024 17:02