-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack week: Lock screen scrubber setting #2536
Hack week: Lock screen scrubber setting #2536
Conversation
@bjtitus Great news! Thanks for tackling this one. Have you considered the other implementation approach mentioned here: By not registering a target for |
Oh! That's good to know. I just avoided that so that we didn't have to re-register the playback commands when changing this setting but I'll take another look at it. Thanks! |
d3254ab
to
34cfdef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @bjtitus ! It's working correctly! I made a test while playing and works
podcasts/PlaybackManager.swift
Outdated
if !Settings.isLockScreenScrubbingDisabled { // Only perform the seek if lock screen scrubbing is enabled | ||
commandCenter.changePlaybackPositionCommand.addTarget { [weak self] event -> MPRemoteCommandHandlerStatus in | ||
|
||
guard let strongSelf = self, let _ = strongSelf.currentEpisode() else { return .noActionableNowPlayingItem } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: guard let self
should be enough here
Fixes #2200
Adds a "Lock Screen Scrubbing" setting to the general player to disable (or enable) scrubbing from the lock screen.
To test
Checklist
CHANGELOG.md
if necessary.