Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rss Chapters FF #2548

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Dec 13, 2024

| 📘 Part of: #2509 |
|:---:|

Fixes #2547

Removing the rssChapters FF

To test

  1. Start the app
  2. Open a podcast with support for chapters. For ex: Chaos Radio
  3. Play an episode
  4. Open the full screen player
  5. Tap on chapters
  6. See if they are displayed

We are giving priority to embedded chapters so to test the rss chapters loading go to line 133 of Chapter Manager and add the following && false to the condition. This will force the use of rss chapters.

Now play another episode of Chaos Radio and see if the chapters show correctly

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.80 milestone Dec 13, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao marked this pull request as ready for review December 13, 2024 15:59
@SergioEstevao SergioEstevao requested a review from a team as a code owner December 13, 2024 15:59
@SergioEstevao SergioEstevao requested review from leandroalonso and removed request for a team December 13, 2024 15:59
@SergioEstevao SergioEstevao merged commit 4ce7cad into trunk Dec 16, 2024
4 of 6 checks passed
@SergioEstevao SergioEstevao deleted the remove/2547_ff_remove_rss_chapters branch December 16, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rssChapters FF
3 participants