[Tooling] Cherry-pick lastest Fastfile tweaks from trunk into release/7.79
#2553
+196
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that those instructions are in the MC scenario, better only keep a single source of truth for those.
We won't need it when we'll move to CI anyway so makes the code simpler to read
Now that the build and the upload are done by separate jobs on CI (both for Prototype Builds in `pipeline.yml` and for Beta/Final builds in `release-builds.yml`), we don't need the previous lanes that did both in one go. IIRC back when we split the lanes in 2 jobs it was argued that it could be useful to keep the old lanes around in case one would need to run them locally. But I'd argue that this makes us keep some dead/legacy code around that won't be maintained, and is likely to go stale, and clutters the Fastfile and makes it less easy to navigate and reason about, so I think it's clearer if we remove this unused code after all.
- Automate adding external tester groups to the build after upload - Use the up-to-date content of the `CHANGELOG.md` for the "What to test" field in TestFlight, removing GitHub links from it.
Co-authored-by: Spencer Transier <17955542+spencertransier@users.noreply.github.com>
AliSoftware
requested review from
danielebogo and
a team
and removed request for
a team
AliSoftware
added
the
[Type] Tooling
danielebogo
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick some improvements of the
Fastfilethat were done intrunkintorelease/7.79—so that I can create a PR to add more improvements on top (stacked PRs)[Tooling] Do some
Fastfilecleanup #2533after_confirming_pushhelper[Tooling] Automate distribution of TestFlight builds to external tester groups #2537
release-toolkitto latest versionTo test
Those changes have already been reviewed as part of them landing in
trunk, so not much to test.Important
Given this also cherry-picks the automation of distributing TestFlight builds to external groups in
release/7.79, that means that this distribution task will already be automated as part of the next 7.79 beta or final release, despite the Release Scenario in MC for7.79still mentioning this task as being manual.This is something the current Release Manager @SergioEstevao might want to be aware of, to not be surprised about the TestFlight builds being already distributed when they'll check TestFlight (if this PR is approved and landed in
release/7.79before the actual release of7.79happens)Alternatively we could decide to only merge this PR and #2554 after
7.79has landed to avoid changing the automation in the middle of7.79(especially given most of Apps Infra will be AFK around Xmas). OTOH, landing this sooner will allow us to fix the automation sooner than later so that we can unblock the tooling project (ref: paaHJt-78B-p2) faster.