Fix teachers not being able to save course settings in the block editor #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
approved these changes
May 2, 2019
donnapep
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2525
This fix is a workaround. The underlying bug is in the block editor code. The full explanation, and the fix, is here: WordPress/gutenberg#15375
Once that fix has been merged into core, this PR may be reverted.
Testing Instructions
Follow the instructions in Block editor: Teachers unable to save course settings #2525. Ensure the submission works properly.
Try submissions with other post types, both core types and CPT's. Ensure that submissions still work from the block editor.
Try submissions with core post types and CPT's (Sensei and non-Sensei) in the classic editor. Ensure that they update as expected.