Polyfill for browsers (looking at you IE11) #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary for transpiling node_modules https://babeljs.io/docs/en/next/configuration.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our browser targets to
> 1%andie >=11(list of browsers), which will affectautoprefixerandbabeltranspilation.It is set up so that only the polyfills necessary for supporting these browsers will be included.
Unfortunately we are going to need to transpile our
node_modulesas well, as some modules are shipping with ES6 code. I first looked into ways we can automatically pick out only the node modules that require transpilation, but with Babel 7 the speed/safety impact of just babelifying everything seems minimal. This is also howcreate-react-appis doing it now.The conversion from
.babelrctobabel.config.jsis necessary for transpiling node_modules.Sad trivia: I think these polyfills are adding around 20 to 40kB (gzipped) to our app bundle 🎺
To test
Quickly check that the app runs in IE11. CSS issues will be dealt with in a separate PR. (We should do a thorough test after that.)