Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop collaboration Step 1 #1573

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Conversation

charliescheer
Copy link
Contributor

Fix

We are removing collaboration from Simplenote. The first step in doing this is to put a notice in the collaboration view that informs users that we will be removing this feature and then links to a url with more details.

Test

  1. go to any note > More menu > collaborate.
  • Confirm that the banner view appears with the retirement notice
  • confirm tapping on the banner view loads safari (the post it points to doesn't exist yet, so that will load 404)

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the [feature] collaborate Anything related to collaboration. label Apr 24, 2024
@charliescheer charliescheer added this to the 4.51 milestone Apr 24, 2024
@charliescheer charliescheer self-assigned this Apr 24, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 24, 2024

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1573-6260e3b-018f2fde-20e2-4704-a308-0a8902031b82 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@spencertransier spencertransier modified the milestones: 4.51, 4.52 Apr 25, 2024
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, just have a copy suggestion so that it matches up to the Android app 👍

Simplenote/BannerView.swift Outdated Show resolved Hide resolved
…apps

Co-authored-by: Dan Roundhill <dan@a8c.com>
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@charliescheer charliescheer merged commit 4c69991 into trunk Apr 30, 2024
10 checks passed
@charliescheer charliescheer deleted the charlie/drop-collaboration-mk1 branch April 30, 2024 18:12
charliescheer added a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] collaborate Anything related to collaboration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants