Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts update part 1: remove existing shortcuts #1578

Merged
merged 3 commits into from
May 7, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

We are reimplementing the current shortcuts using Siri kit intents. This will open up a lot more interesting possibilities for shortcuts, it will also add the intents into shortcuts automatically, (where our current system is using donation to add the intents which means they may not appear in shortcuts) This is going to happen in several steps and the first one is to drop the existing NSUserActivity donation so it no longer is contributed to shortcuts.

Test

Run this PR and then go to the shortcuts app -> Create a new shortcut - > Add action -> Find Simplenote and confirm you don't have new note or open note (you will still see publish to Wordpress, that comes from elsewhere and I don't think needs to be replaced)

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer added this to the 4.52 milestone May 3, 2024
@charliescheer charliescheer self-assigned this May 3, 2024
@charliescheer charliescheer linked an issue May 3, 2024 that may be closed by this pull request
@charliescheer charliescheer changed the title Charlie/1567/remove existing shortcuts Shortcuts update part 1: remove existing shortcuts May 3, 2024
@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1578-c60cea2-018f4090-6c92-4d2a-9ee2-cd8e8d260013 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@charliescheer charliescheer merged commit ed60b6a into trunk May 7, 2024
10 checks passed
@charliescheer charliescheer deleted the charlie/1567/remove-existing-shortcuts branch May 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove existing shortcuts
3 participants