Shortcuts update part 2: refactor widget intents #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliescheer
changed the title
jleandroperez
approved these changes
May 6, 2024
|
You can test the changes in simplenote-ios from this Pull Request by:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Step two for implementing siri kit intents is to refactor the widget intents. Currently the only intents on Simplenote iOS are for the widgets, so the intents extension handler is the class that handles all intents. That is gonna get messy, so I am breaking out the widget intent handlers into their own classes and using the IntentHandler class to martial the intents to the correct handler.
Test
Confirm that you can still add and use all three Simplenote iOS widgets.
Review
(Required) Add instructions for reviewers. For example:
Release