Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts update part 3: Added open new note intent and handler #1580

Merged

Conversation

charliescheer
Copy link
Contributor

Fix

First shortcut to reimplement with siri kit is open new note intent. This shortcut simply opens Simplenote and then creates a new note and opens that in the editor. It doesn't take any parameters or have any actions, so is fairly simple.

Test

  1. Launch the app
  2. go to the Shortcut app, create a new shortcut, add action, find Simplenote and select Open New Note.
  3. Run the shortcut and confirm the app opens and creates a new note

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer added this to the 4.52 milestone May 3, 2024
@charliescheer charliescheer changed the title Added open new note intent and handler Shortcuts update part 3: Added open new note intent and handler May 3, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified that the new Open new Note intent works as expected

:shipit:

@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1580-efcd128-018f53e2-12b1-4a56-8a85-4ec422a2de34 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Base automatically changed from charlie/refactor-widget-intents to trunk May 7, 2024 16:41
@charliescheer charliescheer merged commit 25ca060 into trunk May 7, 2024
11 checks passed
@charliescheer charliescheer deleted the charlie/1568/reimplement-open-note-in-siri-intents branch May 7, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants