Shortcuts update part 4: reimplement open note with siriintents #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliescheer
changed the title
jleandroperez
approved these changes
May 6, 2024
| @@ -32,7 +32,8 @@ | |||
| <array> | |||
| <string>ListWidgetIntent</string> | |||
| <string>NoteWidgetIntent</string> | |||
| <string>SPOpenNewNoteIntent</string> | |||
| <string>OpenNewNoteIntent</string> | |||
| <string>OpenNoteIntent</string> | |||
There was a problem hiding this comment.
Noooow we're talking!! 😎
|
You can test the changes in simplenote-ios from this Pull Request by:
|
Base automatically changed from
charlie/1568/reimplement-open-note-in-siri-intents
to
trunk
May 7, 2024 16:59
Generated by 🚫 Danger |
charliescheer
deleted the
charlie/1568/reimplement-open-note-with-siriintents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Next step in implementing shortcuts with siri kit is to implement the open note shortcut. This allows you to open into Simplenote in any previously selected note.
fixes #1568
Test
Review
(Required) Add instructions for reviewers. For example:
Release