-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcuts update part 4: reimplement open note with siriintents #1581
Shortcuts update part 4: reimplement open note with siriintents #1581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Verified the new Open Note
Intent effectively opens the target note
Nice work!!
@@ -32,7 +32,8 @@ | |||
<array> | |||
<string>ListWidgetIntent</string> | |||
<string>NoteWidgetIntent</string> | |||
<string>SPOpenNewNoteIntent</string> | |||
<string>OpenNewNoteIntent</string> | |||
<string>OpenNoteIntent</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noooow we're talking!! 😎
You can test the changes in simplenote-ios from this Pull Request by:
|
Generated by 🚫 Danger |
Fix
Next step in implementing shortcuts with siri kit is to implement the open note shortcut. This allows you to open into Simplenote in any previously selected note.
fixes #1568
Test
Review
(Required) Add instructions for reviewers. For example:
Release