Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create note with content intent #1583

Merged
merged 4 commits into from
May 13, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented May 9, 2024

Fix

Okay so if we are talking about shortcuts, one I think would be really useful is to be able to paste or write content into a new note and send that over to Simplenote so you can reference it later. So this PR adds that shortcut intent.

With the new "Create New Note" intent you can create a new note with any given content and push it to Simplenote. This shortcut does not require you to launch the app, it is pushed to the server directly from the shortcut and is available on all connected devices.

moves forward #1569
relies on #1582

Test

  1. Launch branch on device (the entitlements need to load on device before they work, so this may be required to access the api token)
  2. Background the app and go to shortcuts
  3. Add a shortcut, add an action, find Simplenote, and select "create new note with content"
  4. Run the shortcut, add some content.
  5. Confirm that the new note is created and available next time you launch Simplenote

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.
(Will add release notes when I add the last shortcut)

@charliescheer charliescheer added this to the 4.52 milestone May 9, 2024
@charliescheer charliescheer self-assigned this May 9, 2024
@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1583-e1e16c3-018f5e5e-e39f-4e90-9015-b0e8cb62cee0 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified that newly created notes sync, and show up in the main app

:shipit:

Base automatically changed from charlie/1569/add-new-shortcuts to trunk May 13, 2024 22:34
@charliescheer charliescheer merged commit 96811b8 into trunk May 13, 2024
13 of 16 checks passed
@charliescheer charliescheer deleted the charlie/1569/add-append-new-note-shortcut branch May 13, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants