Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts: Copy note text intent #1585

Merged
merged 3 commits into from
May 13, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

Okay. so in #1584 I said that was the last shortcut intent I was adding, but then I thought of two more that were too good to pass up.

So first, copy note text. This intent will fetch a selected note or given note and then copy the full text content and return it from the shortcut. This will allow users to connect the content in their notes to any other shortcut they might want to use it with. Pretty neat right?

This intent on it's own doesn't do much, but combined with search intents and output intents it has a lot of potential

Test

(Required) List the steps to test the behavior. For example:
Okay so easiest way to test this one.

  1. build the app, background the app, go to shortcuts, add a shortcut and then tap on add action
  2. Find Simplenote and select "Copy Note Content"
  3. Select a note (we will test accepting a note from another shortcut in the next PR so we can skip that for now)
  4. then at the bottom tap on the x to dismiss the Simplenote modal hiding at the bottom
  5. in the search field that appears type in "clipboard" and then select the copy to clipboard shortcut. This will connect the output of the "Copy Note Content" shortcut to the copy to clipboard shortcut.
  6. go to another app where you can paste text and attempt to past the text from the note you just copied.

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer is to review these changes, but anyone can perform the review.

Release

These changes do not require release notes. (tied up with another PR that did have release notes

@charliescheer charliescheer added this to the 4.52 milestone May 9, 2024
@charliescheer charliescheer self-assigned this May 9, 2024
@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1585-58c13b4-018f5f8d-5d6d-486e-8323-ba43d5921ea4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@charliescheer charliescheer changed the base branch from trunk to charlie/1569/add-search-intent May 9, 2024 22:56
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!!

:shipit:

Base automatically changed from charlie/1569/add-search-intent to trunk May 13, 2024 22:35
@charliescheer charliescheer merged commit 06b65a5 into trunk May 13, 2024
2 of 3 checks passed
@charliescheer charliescheer deleted the charlie/1569/copy-note-text-intent branch May 13, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants